Skip to content

Migrate resource compute router bgp peer test to use transport_tpg#17464

Draft
jcromanu wants to merge 1 commit intoGoogleCloudPlatform:mainfrom
jcromanu:resource_compute_router_bgp_peer_test
Draft

Migrate resource compute router bgp peer test to use transport_tpg#17464
jcromanu wants to merge 1 commit intoGoogleCloudPlatform:mainfrom
jcromanu:resource_compute_router_bgp_peer_test

Conversation

@jcromanu
Copy link
Copy Markdown
Contributor

@jcromanu jcromanu commented May 7, 2026

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

compute: migrated `google_compute_router_bpg_peer_test` resource  to use direct HTTP rather than a client library

@jcromanu jcromanu marked this pull request as draft May 7, 2026 21:14
@github-actions github-actions Bot requested a review from shuyama1 May 7, 2026 21:14
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 7, 2026

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@shuyama1, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@modular-magician
Copy link
Copy Markdown
Collaborator

modular-magician commented May 7, 2026 •
edited
Loading

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 7692119:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 1 file changed, 48 insertions(+), 19 deletions(-)
google-beta provider View Diff 1 file changed, 48 insertions(+), 19 deletions(-)

Test report

Analytics

Total Tests Passed Skipped Affected
1433 1325 91 17
Affected Service Packages
  • compute

Learn how VCR tests work

Step 1: Replaying Mode

Action taken

Found 17 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccComputeInstanceFromTemplate_DiskForceAttach
  • TestAccComputeOrganizationSecurityPolicy_organizationSecurityPolicyWithAdvancedOptionsExample
  • TestAccComputeRouterPeer_AddMd5AuthenticationKey
  • TestAccComputeRouterPeer_EnableDisableIpv6
  • TestAccComputeRouterPeer_Ipv4BasicCreateUpdate
  • TestAccComputeRouterPeer_Ipv6Basic
  • TestAccComputeRouterPeer_UpdateIpv6Address
  • TestAccComputeRouterPeer_UpdateMd5AuthenticationKey
  • TestAccComputeRouterPeer_UpdateRouterAdvertisedRoutePriority
  • TestAccComputeRouterPeer_UpdateRouterCustomLearnedRoutePriority
  • TestAccComputeRouterPeer_addImportAndExportPolicy
  • TestAccComputeRouterPeer_advertiseMode
  • TestAccComputeRouterPeer_basic
  • TestAccComputeRouterPeer_bfd
  • TestAccComputeRouterPeer_enable
  • TestAccComputeRouterPeer_routerApplianceInstance
  • TestAccComputeSecurityPolicyRule_securityPolicyRuleWithBodyExcludeExample

View the build log

Step 2: Recording Mode

Recording Mode Replaying Rerun Test Name
✅ Log ✅ TestAccComputeOrganizationSecurityPolicy_organizationSecurityPolicyWithAdvancedOptionsExample
❌ Error · Log - TestAccComputeInstanceFromTemplate_DiskForceAttach
❌ Error · Log - TestAccComputeRouterPeer_AddMd5AuthenticationKey
❌ Error · Log - TestAccComputeRouterPeer_EnableDisableIpv6
❌ Error · Log - TestAccComputeRouterPeer_Ipv4BasicCreateUpdate
❌ Error · Log - TestAccComputeRouterPeer_Ipv6Basic
❌ Error · Log - TestAccComputeRouterPeer_UpdateIpv6Address
❌ Error · Log - TestAccComputeRouterPeer_UpdateMd5AuthenticationKey
❌ Error · Log - TestAccComputeRouterPeer_UpdateRouterAdvertisedRoutePriority
❌ Error · Log - TestAccComputeRouterPeer_UpdateRouterCustomLearnedRoutePriority
❌ Error · Log - TestAccComputeRouterPeer_addImportAndExportPolicy
❌ Error · Log - TestAccComputeRouterPeer_advertiseMode
❌ Error · Log - TestAccComputeRouterPeer_basic
❌ Error · Log - TestAccComputeRouterPeer_bfd
❌ Error · Log - TestAccComputeRouterPeer_enable
❌ Error · Log - TestAccComputeRouterPeer_routerApplianceInstance
❌ Error · Log - TestAccComputeSecurityPolicyRule_securityPolicyRuleWithBodyExcludeExample

Caution

Issues requiring attention before PR completion

🔴 Initial Recording Failed: Some tests failed during the recording step. See the table above for details.

Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer.

View the build log or the debug logs folder for detailed results.

@jcromanu, @shuyama1 VCR tests complete for 7692119!

@jcromanu jcromanu force-pushed the resource_compute_router_bgp_peer_test branch from 7692119 to 8848ba7 Compare May 8, 2026 20:02
@modular-magician
Copy link
Copy Markdown
Collaborator

modular-magician commented May 8, 2026 •
edited
Loading

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 8848ba7:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 1 file changed, 48 insertions(+), 19 deletions(-)
google-beta provider View Diff 1 file changed, 48 insertions(+), 19 deletions(-)

Test report

Analytics

Total Tests Passed Skipped Affected
1445 1336 93 16
Affected Service Packages
  • compute

Learn how VCR tests work

Step 1: Replaying Mode

Action taken

Found 16 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccComputeInstanceFromTemplate_DiskForceAttach
  • TestAccComputeRouterPeer_AddMd5AuthenticationKey
  • TestAccComputeRouterPeer_EnableDisableIpv6
  • TestAccComputeRouterPeer_Ipv4BasicCreateUpdate
  • TestAccComputeRouterPeer_Ipv6Basic
  • TestAccComputeRouterPeer_UpdateIpv6Address
  • TestAccComputeRouterPeer_UpdateMd5AuthenticationKey
  • TestAccComputeRouterPeer_UpdateRouterAdvertisedRoutePriority
  • TestAccComputeRouterPeer_UpdateRouterCustomLearnedRoutePriority
  • TestAccComputeRouterPeer_addImportAndExportPolicy
  • TestAccComputeRouterPeer_advertiseMode
  • TestAccComputeRouterPeer_basic
  • TestAccComputeRouterPeer_bfd
  • TestAccComputeRouterPeer_enable
  • TestAccComputeRouterPeer_routerApplianceInstance
  • TestAccComputeSecurityPolicyRule_securityPolicyRuleWithBodyExcludeExample

View the build log

Step 2: Recording Mode

Recording Mode Replaying Rerun Test Name
❌ Error · Log - TestAccComputeInstanceFromTemplate_DiskForceAttach
❌ Error · Log - TestAccComputeRouterPeer_AddMd5AuthenticationKey
❌ Error · Log - TestAccComputeRouterPeer_EnableDisableIpv6
❌ Error · Log - TestAccComputeRouterPeer_Ipv4BasicCreateUpdate
❌ Error · Log - TestAccComputeRouterPeer_Ipv6Basic
❌ Error · Log - TestAccComputeRouterPeer_UpdateIpv6Address
❌ Error · Log - TestAccComputeRouterPeer_UpdateMd5AuthenticationKey
❌ Error · Log - TestAccComputeRouterPeer_UpdateRouterAdvertisedRoutePriority
❌ Error · Log - TestAccComputeRouterPeer_UpdateRouterCustomLearnedRoutePriority
❌ Error · Log - TestAccComputeRouterPeer_addImportAndExportPolicy
❌ Error · Log - TestAccComputeRouterPeer_advertiseMode
❌ Error · Log - TestAccComputeRouterPeer_basic
❌ Error · Log - TestAccComputeRouterPeer_bfd
❌ Error · Log - TestAccComputeRouterPeer_enable
❌ Error · Log - TestAccComputeRouterPeer_routerApplianceInstance
❌ Error · Log - TestAccComputeSecurityPolicyRule_securityPolicyRuleWithBodyExcludeExample

Caution

Issues requiring attention before PR completion

🔴 Initial Recording Failed: Some tests failed during the recording step. See the table above for details.

Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer.

View the build log or the debug logs folder for detailed results.

@jcromanu, @shuyama1 VCR tests complete for 8848ba7!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@shuyama1 shuyama1 Awaiting requested review from shuyama1

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jcromanu @modular-magician